Recreate main output every time it is turned on#1198
Recreate main output every time it is turned on#1198Trouffman merged 11 commits intoDistroAV:masterfrom
Conversation
|
When testing I get Also result in a black screen after changing the profile. Can you check that the merge from master was correct? |
|
I see the 'Tried to reset..' line in the log. Never tried changing profiles in my testing. Will look at that. They added a new signal to address this in OBS. More details here: #1096
|
|
The |
|
Seems with this PR, we are no longer outputting Preview scenes. The preview shows up as a NDI source, but it doesn't output anything. Will try and address it in PR 1148 I believe it is related to Preview and Main using the same OBS output. |
|
The issue introduced by this PR is fixed by : #1237 Note for future self looking here : "try to keep the codebase between main output and preview output logic as close as possible!" |
The problem exists because an output would be created even when no main output was selected. When the user went to change the color format in the OBS Settings->Advanced dialog, or any setting in OBS Settings ->Video, this would invalidate the video output in DistroAV NDI Settings. Then when Main output was turned back on, OBS would crash because output->video is corrupted.
This makes the changes to main-output look big but it was mainly removing an indented if condition. In summary we always call main_output_deinit in main_output_init, and then if it is not enabled, we return, otherwise we create the output and start it every time it is enabled.
This fixes:
#1147
#1195