Skip to content

Fix OBS Source (temporary) with upstream fix not released yet.#1252

Merged
Trouffman merged 1 commit intomasterfrom
fix-githubactionmacos
Apr 23, 2025
Merged

Fix OBS Source (temporary) with upstream fix not released yet.#1252
Trouffman merged 1 commit intomasterfrom
fix-githubactionmacos

Conversation

@Trouffman
Copy link
Collaborator

TODO: Revert this to use obsproject/obs-studio for release tagged after 31.0.0.

Important :

  • This PR Should be reverted to new obs-plugintemplate when the fix (macos SDK detection) is available in a tagged release.
  • This PR is "ahead" of the obs-plugin-template & obs-studio 31.0.3 tag.
  • This PR relies only on a fork of the 31.0.0 code-base from obs-studio OBS Project.

This fix solves:

  • Mac OS SDK detection in the OBS source both for local build & github action.

What has been done :

Also similar to :
obsproject/obs-studio#12076

  • Added a 31.0.0-fix tag containing this unique change
  • Update BuildSpecs to use the fixed version of the OBS source instead of the upstream.

IMPORTANT

This is an exceptional & temporary change to allow the project to create new releases.

This MUST be reverted to the proper Obs upstream buildspec as soon as the obs-plugin-template implement the required changes.

TODO: Revert this to use obsproject/obs-studio for release tagged after 31.0.3.
Copy link
Contributor

@BitRate27 BitRate27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed the tag on our obs-studio fork exists, and saw the temporary changes there. Doesn't appear to need an approval there as it is a straight commit/tag.

@Trouffman Trouffman merged commit 5fe7a86 into master Apr 23, 2025
6 checks passed
@Trouffman Trouffman deleted the fix-githubactionmacos branch April 23, 2025 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants