Bump base plugin template files & OBS 31.1.1 requirement#1406
Merged
Bump base plugin template files & OBS 31.1.1 requirement#1406
Conversation
Bump OBS 31.1.1 requirement
There was a problem hiding this comment.
Pull request overview
Updates DistroAV’s base plugin/build tooling to align with recent obs-plugintemplate changes and raises the minimum supported OBS version to 31.1.1, including corresponding CI/toolchain and macOS target bumps.
Changes:
- Bump minimum OBS requirement to 31.1.1 (code + docs) and update buildspec OBS/prebuilt/Qt dependency versions.
- Update formatting/CI toolchain to clang-format 19 and refresh template config defaults (e.g., macOS deployment target 12.0).
- Template/CI script adjustments (Ubuntu deps install, macOS checks, action inputs).
Reviewed changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/plugin-main.h | Raises minimum OBS version constant to 31.1.1. |
| cmake/common/buildspec_common.cmake | Updates OBS configure flags used when building bundled dependencies. |
| buildspec.json | Bumps OBS/prebuilt/Qt versions and hashes. |
| build-aux/.run-format.zsh | Updates required clang-format version to 19.1.1. |
| README.md | Updates documented OBS minimum version. |
| CMakePresets.json | Raises macOS deployment target to 12.0 and updates preset descriptions. |
| .github/scripts/utils.zsh/setup_ubuntu | Adjusts Ubuntu dependency installation list. |
| .github/scripts/utils.zsh/check_macos | Simplifies macOS checks (now only Homebrew). |
| .github/actions/run-clang-format/action.yaml | Switches CI to install/use clang-format@19. |
| .github/actions/build-plugin/action.yaml | Adds codesignTeam input and exports it as env var. |
| .github/ISSUE_TEMPLATE/3_support.yml | Updates support checklist items and adds AI/human review checkboxes. |
| .github/ISSUE_TEMPLATE/1_bug.yml | Tightens bug report pre-check requirements and updates examples. |
| .gersemirc | Removes previously commented/invalid options. |
| .clang-format | Tweaks formatting configuration to match updated clang-format behavior. |
Comments suppressed due to low confidence (1)
.github/scripts/utils.zsh/check_macos:6
check_macosno longer enforces a minimum macOS version, but the build presets now target macOS 12.0+ (CMAKE_OSX_DEPLOYMENT_TARGET=12.0). Reintroduce the version check (updated to 12.0) so contributors running the script locally get an explicit, early failure instead of later/less clear build errors.
autoload -Uz is-at-least log_group log_info log_error log_status
log_info 'Checking for Homebrew...'
if (( ! ${+commands[brew]} )) {
log_error 'No Homebrew command found. Please install Homebrew (https://brew.sh)'
return 2
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 14 out of 14 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 14 out of 14 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (1)
.github/scripts/utils.zsh/check_macos:7
check_macosno longer validates the host macOS version, but the project now targets macOS 12.0+ viaCMAKE_OSX_DEPLOYMENT_TARGET. Without this guard, builds on older runners/dev machines will fail later with less actionable toolchain/SDK errors. Consider reinstating the version check (updated to 12.0) so the script fails fast with a clear message.
autoload -Uz is-at-least log_group log_info log_error log_status
log_info 'Checking for Homebrew...'
if (( ! ${+commands[brew]} )) {
log_error 'No Homebrew command found. Please install Homebrew (https://brew.sh)'
return 2
}
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes :
DistroAV