Skip to content

Moved all constant dimensions to a separate file #91#122

Merged
sapatevaibhav merged 5 commits intoEkaAI-Tech:masterfrom
Gaurav-Kushwaha-1225:dimensions
May 25, 2024
Merged

Moved all constant dimensions to a separate file #91#122
sapatevaibhav merged 5 commits intoEkaAI-Tech:masterfrom
Gaurav-Kushwaha-1225:dimensions

Conversation

@Gaurav-Kushwaha-1225
Copy link
Contributor

@Gaurav-Kushwaha-1225 Gaurav-Kushwaha-1225 commented May 20, 2024

  • I have solved the issue Move dimentions to seperate file. #91
  • I have created a file named as const_dimensions.dart that has all the constant dimensions used for widgets like Container, SizedBox, etc.
  • Some, exceptional values of dimensions that are used only at some places are kept in list named as exceptions.

@sapatevaibhav sapatevaibhav requested a review from nehal076 May 22, 2024 07:43
@sapatevaibhav
Copy link
Collaborator

hellow new merge is causing conflicts please resolve them

@Gaurav-Kushwaha-1225
Copy link
Contributor Author

@sapatevaibhav There are no conflicts now and ready to merge.

@sapatevaibhav sapatevaibhav merged commit d85b116 into EkaAI-Tech:master May 25, 2024
@sapatevaibhav sapatevaibhav added gssoc Girl Script Summer of Code level2 Medium to solve issues for GSSoC'24 labels May 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gssoc Girl Script Summer of Code level2 Medium to solve issues for GSSoC'24

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants