Align Explore Page AppBar with Home Page Style#195
Merged
sapatevaibhav merged 2 commits intoEkaAI-Tech:masterfrom Jul 2, 2024
Merged
Align Explore Page AppBar with Home Page Style#195sapatevaibhav merged 2 commits intoEkaAI-Tech:masterfrom
sapatevaibhav merged 2 commits intoEkaAI-Tech:masterfrom
Conversation
Collaborator
|
|
Contributor
Author
|
@sapatevaibhav , oky.... |
Contributor
Author
|
@sapatevaibhav , I have made the changes in the explore_page_better branch, kindly review,
it is working fine now... |
Contributor
Author
|
fixes issue: Make explore page better #193 |
Contributor
Author
|
@sapatevaibhav , Please, let me know, why are you not merging this pull request, Is there any need to do some more changes??? |
Collaborator
|
I'll merge it tonight after testing on my device as I'm busy with some other stuff that is being late😕. |
Contributor
Author
|
Okay, Thanks for informing.... |
sapatevaibhav
added
gssoc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request modifies the ExplorePage to ensure that its AppBar is consistent with the AppBar used on the Home Page. Specifically, the scrollable SliverAppBar was replaced with a fixed AppBar.
Removed SliverAppBar: The SliverAppBar was removed from the ExplorePage.
Added Fixed AppBar: A standard AppBar was added to ensure it remains fixed while the page content scrolls.
Updated Body Content: The main content was encapsulated in a SliverList to maintain the scrollable content area without affecting the fixed AppBar.
explore_page.mp4
@sapatevaibhav ,Please review these changes and merge them into the master branch if everything looks good. Thank you!
fixes issue: Make explore page better #193