Skip to content

rpc!: change tweakfedpegscript to output both p2wsh and p2shwsh addresses #1522

Merged
psgreco merged 1 commit intoElementsProject:masterfrom
delta1:2026-01-tweakfedpegscript
Jan 20, 2026
Merged

rpc!: change tweakfedpegscript to output both p2wsh and p2shwsh addresses #1522
psgreco merged 1 commit intoElementsProject:masterfrom
delta1:2026-01-tweakfedpegscript

Conversation

@delta1
Copy link
Member

@delta1 delta1 commented Jan 13, 2026 •
edited
Loading

Changes tweakfedpegscript to return both p2wsh and p2shwsh version of
the tweaked address.

"address" has been removed from the tweakfedpegscript RPC result and replaced with "p2wsh" and
"p2shwsh" addresses.

@jsarenik
Copy link

jsarenik commented Jan 13, 2026

Tested ACK a4eeed9

@delta1 delta1 marked this pull request as draft January 13, 2026 11:21
@delta1 delta1 force-pushed the 2026-01-tweakfedpegscript branch from a4eeed9 to f2bd052 Compare January 20, 2026 10:03
@delta1 delta1 marked this pull request as ready for review January 20, 2026 10:03
@delta1 delta1 changed the title rpc: change tweakfedpegscript to output P2WSH address rpc!: change tweakfedpegscript to output both p2wsh and p2shwsh addresses Jan 20, 2026
@jsarenik
Copy link

jsarenik commented Jan 20, 2026 •
edited
Loading

NACK a4eeed9, have read the diff

jsarenik
jsarenik suggested changes Jan 20, 2026
View reviewed changes
Copy link

@jsarenik jsarenik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

p2shwsh seems very non-standard and I do not know what is meant by that. Did you mean following?

sh(wpkh), Nested Segwit, P2SH-segwit
(all above are the same thing, how people call it, better do not add another)

@delta1
Copy link
Member Author

delta1 commented Jan 20, 2026

It's wrapped segwit.

https://river.com/learn/terms/w/wrapped-segwit/

@delta1
rpc!: change tweakfedpegscript to output P2WSH address
5d64e89 
Changes tweakfedpegscript to return both p2wsh and p2shwsh version of
the tweaked address.

"address" has been removed from the result and replaced with "p2wsh" and
"p2shwsh".
@delta1 delta1 force-pushed the 2026-01-tweakfedpegscript branch from f2bd052 to 5d64e89 Compare January 20, 2026 13:03
@tomt1664
Copy link
Member

tomt1664 commented Jan 20, 2026

Tested ACK 5d64e89

@psgreco psgreco merged commit 6d29a59 into ElementsProject:master Jan 20, 2026
14 checks passed
@jsarenik
Copy link

jsarenik commented Jan 20, 2026 •
edited
Loading

It's wrapped segwit.

https://river.com/learn/terms/w/wrapped-segwit/

Thanks for the link.

One can not find it in Bitcoin Core nor in Elements Core doc and there's nothing like term "wrapped segwit" in the sources making the words ungreppable in the repo.

I just think that calling the same thing in multiple different ways may be confusing for the newcomers.

Update: there's a mention on a very long line here:

elements/doc/external-signer.md

Line 91 in 6d29a59

A future extension could add an optional return field with device capabilities. Perhaps a descriptor with wildcards. For example: `["pkh("44'/0'/$'/{0,1}/*"), sh(wpkh("49'/0'/$'/{0,1}/*")), wpkh("84'/0'/$'/{0,1}/*")]`. This would indicate the device supports legacy, wrapped SegWit and native SegWit. In addition it restricts the derivation paths that can used for those, to maintain compatibility with other wallet software. It also indicates the device, or the driver, doesn't support multisig.

And

elements/doc/release-notes/release-notes-0.16.0.md

Line 161 in 6d29a59

* A new field `iswitness` is True for P2WPKH and P2WSH addresses ("bc1..." addresses), but not for P2SH-wrapped segwit addresses (see below).

And although not self-standing

elements/doc/release-notes/release-notes-0.18.0.md

Line 432 in 6d29a59

P2SH-wrapped segwit addresses will continue to be provided if the user

So I've just never seen it in Bitcoin context yet.

jsarenik added a commit to jsarenik/bitcoin-faucet-shell that referenced this pull request Jan 20, 2026
@jsarenik
about: Add "Wrapped Segwit" with a link
962f9d7 
Adds yet another way to name a Nested Segwit.

See ElementsProject/elements#1522
@delta1 delta1 deleted the 2026-01-tweakfedpegscript branch January 21, 2026 04:47
@psgreco psgreco mentioned this pull request Feb 1, 2026
Merged
delta1 added a commit to delta1/elements that referenced this pull request Feb 11, 2026
@delta1
Merge 6d29a59 into merged_master (Elements PR ElementsProject#1522)
dd57849
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@jsarenik jsarenik jsarenik requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@delta1 @jsarenik @tomt1664 @psgreco