Prepare 23.3.2rc2#1531
Merged
delta1 merged 9 commits intoElementsProject:elements-23.xfrom Feb 4, 2026
Merged
Conversation
The problem with including <simplicity/elements/env.h> in interpreter.h is that now everyone who needs to include interpreter.h also needs access to Simplicity's header files too. This commit breaks that dependency chain by using forward declarations. It will pay signifigant dividends when elements switches to CMake.
…ation 6c7788a Avoid Simplicity header dependency propogation (Russell O'Connor) Pull request description: The problem with including <simplicity/elements/env.h> in interpreter.h is that now everyone who needs to include interpreter.h also needs access to Simplicity's header files too. This commit breaks that dependency chain by using forward declarations. It will pay signifigant dividends when elements switches to CMake. ACKs for top commit: delta1: ACK 6c7788a; built and tested locally apoelstra: ACK 6c7788a; successfully ran local tests Tree-SHA512: 78d043a094f0a2bb51e0f103313ae568b42ec2852d8fe9a3fbbcad9c0fbf6829ef1347f83bfd361547ec165c01965e7342188a38d8faacfcf90ef70c5b7001f6
…ging PRs 8f28d82 docs: add github-merge.py process for merging PRs (Byron Hambly) Pull request description: Documents how to merge PRs using the github-merge.py script from Bitcoin maintainer tools repo. ACKs for top commit: psgreco: ACK 8f28d82 Tree-SHA512: b263dd7715fa71926ceeae053e453a4a19b64fa89c88cb0f84fa15bafbcc1051f35ca4f28a05f41dfc8d3af1d1de9eb2bb6cd832867cf7d7d7772a3c7267777b
…or qr uri 4c79d5a fix: use liquidnetwork or liquidtestnet for uri in elements mode (Byron Hambly) Pull request description: fixes ElementsProject#1529 ACKs for top commit: tomt1664: ACK 4c79d5a psgreco: ACK 4c79d5a Tree-SHA512: 00862c3851bd1663ed17dfde9ef155840d4d735b3e61ad890155dccdc9cb7fb4fc086021a9ae1a1030ff8e809dc6ffb46a5aeed35d3c5625b44f65ec6cdae421
Member
|
ACK 73db0cf; diff looks as expected, tested locally successfully |
delta1
approved these changes
Feb 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates master to 6bb916a which includes fixes for simplicity header dependency and qr code generation for QT