Make new actually working master blinding calls, test#549
Merged
stevenroose merged 1 commit intoElementsProject:masterfrom Apr 1, 2019
Merged
Make new actually working master blinding calls, test#549stevenroose merged 1 commit intoElementsProject:masterfrom
stevenroose merged 1 commit intoElementsProject:masterfrom
Conversation
instagibbs
force-pushed
the
test_blind_recovery
branch
from
c6d4bad to
9acbd24
Compare
stevenroose
added a commit
that referenced
this pull request
Apr 1, 2019
9acbd24 Make new actually working master blinding calls, test (Gregory Sanders) Pull request description: resolves #547 Previous API was improperly overloading the specific blinding key calls, and incorrectly on top of that. Instead implement `importmasterblindingkey` and `dumpmasterblindingkey` and check that `dumpwallet` details are enough to recover same blinded wallet addresses. Tree-SHA512: d9d954d1cb787182d99b464cc6a80e8383d3ea71e432e6fd0e244b5f5a460b9adfcdc14e38fe841c5a5e2fef1345da78217d519a23a804d5066998828103efd1
Contributor
|
tACK 9acbd24 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #547
Previous API was improperly overloading the specific blinding key calls, and incorrectly on top of that.
Instead implement
importmasterblindingkeyanddumpmasterblindingkeyand check thatdumpwalletdetails are enough to recover same blinded wallet addresses.