bad gossip after merging the gossip rework #7043
Description
Following the merge of #6941 we are now getting some Bad gossip errors again:
```request = <SubRequest 'teardown_checks' for <Function test_pay_exclude_node>>
@pytest.fixture
def teardown_checks(request):
"""A simple fixture to collect errors during teardown.
We need to collect the errors and raise them as the very last step in the
fixture tree, otherwise some fixtures may not be cleaned up
correctly. Require this fixture in all other fixtures that need to either
cleanup before reporting an error or want to add an error that is to be
reported.
"""
errors = TeardownErrors()
yield errors
if errors.has_errors():
# Format a nice list of everything that went wrong and raise an exception
request.node.has_errors = True
> raise ValueError(str(errors))
E ValueError:
E Node errors:
E - lightningd-3: had bad gossip messages
E Global errors:
contrib/pyln-testing/pyln/testing/fixtures.py:206: ValueErrorThe connection to that PR is just a hunch, but it would be a
coincidence that we touch the gossip and then it breaks independently.
The specific error logs are these:
32cf15d1ad9c4a08d26eab1918f732d8ef8fdc6abb9640bf3db174372c491304e
2024-02-05T18:36:23.9025203Z lightningd-3 2024-02-05T18:21:11.239Z DEBUG 032cf15d1ad9c4a08d26eab1918f732d8ef8fdc6abb9640bf3db174372c491304e-channeld-chan#2: peer_in WIRE_ANNOUNCEMENT_SIGNATURES
2024-02-05T18:36:23.9025562Z lightningd-5 2024-02-05T18:21:11.244Z DEBUG hsmd: Client: Received message 4 from client
2024-02-05T18:36:23.9026528Z lightningd-3 2024-02-05T18:21:11.249Z DEBUG 032cf15d1ad9c4a08d26eab1918f732d8ef8fdc6abb9640bf3db174372c491304e-chan#2: channel_gossip: received announcement sigs for 114x1x0 (we have 114x1x0)
2024-02-05T18:36:23.9027233Z lightningd-1 2024-02-05T18:21:11.269Z DEBUG 0382ce59ebf18be7d84677c2e35f23294b9992ceca95491fcf8a56c6cb2d9de199-gossipd: handle_recv_gossip: WIRE_CHANNEL_UPDATE
2024-02-05T18:36:23.9027928Z lightningd-5 2024-02-05T18:21:11.270Z DEBUG 035d2b1192dfba134e10e540875d366ebc8bc353d5aa766b80c090b39c3a5d885d-connectd: peer_out WIRE_ANNOUNCEMENT_SIGNATURES
2024-02-05T18:36:23.9028286Z lightningd-5 2024-02-05T18:21:11.271Z DEBUG hsmd: Client: Received message 4 from client
2024-02-05T18:36:23.9029139Z lightningd-5 2024-02-05T18:21:11.271Z DEBUG 035d2b1192dfba134e10e540875d366ebc8bc353d5aa766b80c090b39c3a5d885d-channeld-chan#2: handle_funding_depth: Setting short_channel_ids[LOCAL] to 114x1x0
2024-02-05T18:36:23.9029491Z lightningd-5 2024-02-05T18:21:11.272Z DEBUG hsmd: Client: Received message 3 from client
2024-02-05T18:36:23.9030199Z lightningd-5 2024-02-05T18:21:11.272Z DEBUG 035d2b1192dfba134e10e540875d366ebc8bc353d5aa766b80c090b39c3a5d885d-channeld-chan#2: billboard: Channel ready for use.
2024-02-05T18:36:23.9030976Z lightningd-1 2024-02-05T18:21:11.274Z DEBUG 0382ce59ebf18be7d84677c2e35f23294b9992ceca95491fcf8a56c6cb2d9de199-gossipd: Received channel_update for channel 112x1x0/0 now ACTIVE
2024-02-05T18:36:23.9031691Z lightningd-1 2024-02-05T18:21:11.275Z DEBUG 0382ce59ebf18be7d84677c2e35f23294b9992ceca95491fcf8a56c6cb2d9de199-gossipd: handle_recv_gossip: WIRE_NODE_ANNOUNCEMENT
2024-02-05T18:36:23.9032700Z lightningd-1 2024-02-05T18:21:11.277Z DEBUG 0382ce59ebf18be7d84677c2e35f23294b9992ceca95491fcf8a56c6cb2d9de199-gossipd: Received node_announcement for node 032cf15d1ad9c4a08d26eab1918f732d8ef8fdc6abb9640bf3db174372c491304e
2024-02-05T18:36:23.9033088Z lightningd-5 2024-02-05T18:21:11.280Z DEBUG gossipd: inject_gossip: WIRE_CHANNEL_ANNOUNCEMENT
2024-02-05T18:36:23.9033497Z lightningd-5 2024-02-05T18:21:11.281Z DEBUG gossipd: REPLY WIRE_GOSSIPD_ADDGOSSIP_REPLY with 0 fds
2024-02-05T18:36:23.9033850Z lightningd-5 2024-02-05T18:21:11.281Z DEBUG gossipd: inject_gossip: WIRE_CHANNEL_UPDATE
2024-02-05T18:36:23.9034306Z lightningd-5 2024-02-05T18:21:11.282Z DEBUG gossipd: Received channel_update for channel 114x1x0/0 now ACTIVE
2024-02-05T18:36:23.9034705Z lightningd-5 2024-02-05T18:21:11.283Z DEBUG gossipd: REPLY WIRE_GOSSIPD_ADDGOSSIP_REPLY with 0 fds
2024-02-05T18:36:23.9035132Z lightningd-5 2024-02-05T18:21:11.283Z DEBUG gossipd: REPLY WIRE_GOSSIPD_NEW_BLOCKHEIGHT_REPLY with 0 fds
2024-02-05T18:36:23.9035838Z lightningd-3 2024-02-05T18:21:11.298Z DEBUG 032cf15d1ad9c4a08d26eab1918f732d8ef8fdc6abb9640bf3db174372c491304e-gossipd: handle_recv_gossip: WIRE_CHANNEL_UPDATE
2024-02-05T18:36:23.9036306Z lightningd-3 2024-02-05T18:21:11.309Z DEBUG hsmd: Client: Received message 4 from client
2024-02-05T18:36:23.9036872Z lightningd-3 2024-02-05T18:21:11.312Z UNUSUAL lightningd: Bad gossip order: could not find channel 112x1x0 for peer's channel update
2024-02-05T18:36:23.9037216Z lightningd-3 2024-02-05T18:21:11.315Z DEBUG hsmd: Client: Received message 3 from client
2024-02-05T18:36:23.9037935Z lightningd-3 2024-02-05T18:21:11.316Z DEBUG 032cf15d1ad9c4a08d26eab1918f732d8ef8fdc6abb9640bf3db174372c491304e-gossipd: handle_recv_gossip: WIRE_NODE_ANNOUNCEMENT
2024-02-05T18:36:23.9039010Z lightningd-3 2024-02-05T18:21:11.326Z DEBUG 032cf15d1ad9c4a08d26eab1918f732d8ef8fdc6abb9640bf3db174372c491304e-gossipd: Bad gossip order: node_announcement: unknown node 032cf15d1ad9c4a08d26eab1918f732d8ef8fdc6abb9640bf3db174372c491304e
2024-02-05T18:36:23.9039698Z lightningd-3 2024-02-05T18:21:11.327Z DEBUG 032cf15d1ad9c4a08d26eab1918f732d8ef8fdc6abb9640bf3db174372c491304e-gossipd: handle_recv_gossip: WIRE_CHANNEL_UPDATE
2024-02-05T18:36:23.9040521Z lightningd-3 2024-02-05T18:21:11.328Z DEBUG 032cf15d1ad9c4a08d26eab1918f732d8ef8fdc6abb9640bf3db174372c491304e-gossipd: Bad gossip order: Unknown channel 112x1x0
2024-02-05T18:36:23.9040906Z lightningd-3 2024-02-05T18:21:11.328Z DEBUG gossipd: inject_gossip: WIRE_CHANNEL_ANNOUNCEMENT
2024-02-05T18:36:23.9041310Z lightningd-3 2024-02-05T18:21:11.329Z DEBUG gossipd: REPLY WIRE_GOSSIPD_ADDGOSSIP_REPLY with 0 fds
2024-02-05T18:36:23.9041667Z lightningd-3 2024-02-05T18:21:11.330Z DEBUG gossipd: inject_gossip: WIRE_CHANNEL_UPDATE
2024-02-05T18:36:23.9042115Z lightningd-3 2024-02-05T18:21:11.330Z DEBUG gossipd: Received channel_update for channel 114x1x0/1 now ACTIVE
2024-02-05T18:36:23.9042517Z lightningd-3 2024-02-05T18:21:11.331Z DEBUG gossipd: REPLY WIRE_GOSSIPD_ADDGOSSIP_REPLY with 0 fds