Bolt11 cleanups, parsing fix#5891
Merged
endothermicdev merged 3 commits intoElementsProject:masterfrom Jan 25, 2023
Merged
Conversation
Also, we don't need to pass the total length to the field parsers, just the length for this field (confusingly, this was called "data_length"). Signed-off-by: Rusty Russell <[email protected]>
And make pull_bits return a uniform error message, since that's what callers want, rather than asserting success. Signed-off-by: Rusty Russell <[email protected]> Changelog-Fixed: pay: don't assert() on malformed BOLT11 strings.
Decode functions are now almost entirely uniform, so just use a table. Signed-off-by: Rusty Russell <[email protected]>
rustyrussell
force-pushed
the
bolt11-cleanups
branch
from
43e12fe to
f1bd932
Compare
endothermicdev
approved these changes
Jan 24, 2023
Collaborator
endothermicdev
left a comment
endothermicdev
left a comment
There was a problem hiding this comment.
I tried my best to be critical, but I like these changes, especially the pull_bits error handling.
ACK f1bd932
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.