channeld: don't spin trying to send commitment while waiting.#6107
Merged
rustyrussell merged 1 commit intoElementsProject:masterfrom Mar 22, 2023
Merged
channeld: don't spin trying to send commitment while waiting.#6107rustyrussell merged 1 commit intoElementsProject:masterfrom
rustyrussell merged 1 commit intoElementsProject:masterfrom
Conversation
We would sleep for 10msec (default) and try again, spamming the logs every second. But we're waiting for revoke_and_ack, and that handler already sets off the timer, so there's no need to spin at all! Fixes: ElementsProject#6077 Changelog-Fixed: `channeld`: no longer spin and spam logs when waiting for revoke_and_ack. Signed-off-by: Rusty Russell <[email protected]>
vincenzopalazzo
approved these changes
Mar 21, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We would sleep for 10msec (default) and try again, spamming the logs every second. But we're waiting for revoke_and_ack, and that handler already sets off the timer, so there's no need to spin at all!
Fixes: #6077
Changelog-Fixed:
channeld: no longer spin and spam logs when waiting for revoke_and_ack.