Skip to content

cln-grpc: Add some missing states to HtlcState#6323

Merged
rustyrussell merged 1 commit intoElementsProject:masterfrom
cdecker:20230609-missing-htlc-states
Jun 23, 2023
Merged

cln-grpc: Add some missing states to HtlcState#6323
rustyrussell merged 1 commit intoElementsProject:masterfrom
cdecker:20230609-missing-htlc-states

Conversation

@cdecker
Copy link
Member

@cdecker cdecker commented Jun 12, 2023

Potentially fixes #6318

The issue talks about cln-rpc however as far as I can see the code already had all states (probably its the cln-rpc published on crates.io which is lagging a bit). But the cln-grpc is indeed missing those variants, so I backfilled them.

Copy link
Contributor

@rustyrussell rustyrussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack 7ff438c

@rustyrussell rustyrussell added this to the v23.05.2 milestone Jun 20, 2023
@rustyrussell rustyrussell modified the milestones: v23.05.2, v23.08 Jun 21, 2023
@rustyrussell rustyrussell force-pushed the 20230609-missing-htlc-states branch from 7ff438c to f1e8da7 Compare June 23, 2023 04:33
@rustyrussell
Copy link
Contributor

Rebased for generated file conflicts.

@rustyrussell rustyrussell merged commit 6507d34 into ElementsProject:master Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

gRPC ListPeers fails due to missing variant SENT_REMOVE_COMMIT

2 participants