fuzz: test bolt11 decoding#6750
Conversation
vincenzopalazzo
left a comment
vincenzopalazzo
left a comment
There was a problem hiding this comment.
Concept ACK d58419f
waiting the CI
vincenzopalazzo
left a comment
vincenzopalazzo
left a comment
There was a problem hiding this comment.
make check-includes is failing, I think there is some include in the wrong order
dergoegge
force-pushed
the
2023-10-fuzz-bolt11
branch
from
d58419f to
9cbdcee
Compare
Thanks, should be fixed now |
|
Nice! I was working on a similar fuzz test, though a little simpler than this one. I'll give this a review soon. |
morehouse
left a comment
morehouse
left a comment
There was a problem hiding this comment.
Very nice mutator. Mostly easy-to-fix comments inline.
I imagine a custom cross-over mutator would also be useful, but that's something that could be added later (if you don't have time for it, I'd be happy to work on it).
dergoegge
left a comment
dergoegge
left a comment
There was a problem hiding this comment.
Thanks for the review! I think I addressed all your comments.
I imagine a custom cross-over mutator would also be useful, but that's something that could be added later (if you don't have time for it, I'd be happy to work on it).
Probably don't have the time atm but would be interested to see what you come up with.
I've been trying to find a good collection of bolt11 strings to seed the corpus, so far I've only used the ones from the spec. Are you aware of any others we could use?
dergoegge
force-pushed
the
2023-10-fuzz-bolt11
branch
from
9cbdcee to
12951a6
Compare
morehouse
left a comment
morehouse
left a comment
There was a problem hiding this comment.
Looks pretty good to me. Just one more fix needed for the dummy input.
dergoegge
force-pushed
the
2023-10-fuzz-bolt11
branch
from
12951a6 to
ef32783
Compare
3 participants
No description provided.