Offers deprecate string recurrence#7034
Conversation
It can actually be useful for more complex parameter parsing, as we're about to see. Signed-off-by: Rusty Russell <[email protected]>
Christian points out that this makes the type harder, and it's just awkward. Changelog-EXPERIMENTAL: JSON-RPC: Deprecated `offer` parameter `recurrence_base` with `@` prefix: use `recurrence_start_any_period`. Changelog-EXPERIMENTAL: JSON-RPC: Added `offer` parameter `recurrence_start_any_period`. Signed-off-by: Rusty Russell <[email protected]>
4533e45 to
9d7055d
Compare
|
This is missing the update to the In the meantime, thank you very much for this @rustyrussell ^^ |
|
Turns out this doesn't address the schema issues we have: This error is caused in #6896 after applying this patch. We need to remove the shorthand usage of |
|
Nevertheless, this is a good change, let's merge it asap, and then address that request schema issue, using redundant argument encodings. |
|
That's different. That json schema is wrong: recurrence is a string, never a raw number. If we wanted, we could make it an object, in which case we would use a number and a string (an enum in JSON terms). But using the draft bolt encoding here is wrong, since it's highly experimental and subject to change. TBH, I would not support recurrence in the GRPC API for now. |
@cdecker points out that it's ugly to have a string variant, and I agree. Deprecate now (quickly, it's experimental) so GRPC/Rust bindings don't have to support it!