Add --bitcoin-rpcclienttimeout CLI parameter#7095
Conversation
s373nZ
force-pushed
the
2817-bitcoin-rpcclienttimeout-parameter
branch
from
0863ea7 to
cae2cd6
Compare
s373nZ
force-pushed
the
2817-bitcoin-rpcclienttimeout-parameter
branch
from
56affbf to
7b54c36
Compare
|
Very nice change, thanks for contributing @s373nZ. It just missed the release window for v24.02, but I'll mark it for inclusion in v25.05 👍 |
|
@cdecker Gentle reminder -- is this still slated for inclusion in |
@endothermicdev is the release captain for this release so it'll be his decision, buy I'm happy to shepherd this one through if it qualifies (marked for inclusion and I'm volunteering to rebase and/or fix breakage if conflicts arise). |
|
Looks good. Nit: rather than passing through the bitcoind sematics, could the CLN option be named something similar to the existing |
|
@endothermicdev I noticed that the
and tried to follow in line with those, omitting the hyphenation -- a best guess. I'm happy to change the parameter name to |
3 participants
This is a first pass at #2817. It adds a
--bitcoin-rpcclienttimeoutparameter tobcli. It seems those parameters are automatically pulled in aslightningdparameters as well. Instead of setting the default value at900per thebitcoind, we set it to match theretry_timeoutand then choose the maximum value from arguments gathered by the user.Don't have much experience in C, but open to learn and contribute to this project where I can.