6996 Fix Unable to generate P2TR address via gRPC#7146
Closed
rox1338 wants to merge 1 commit intoElementsProject:masterfrom
Closed
6996 Fix Unable to generate P2TR address via gRPC#7146rox1338 wants to merge 1 commit intoElementsProject:masterfrom
rox1338 wants to merge 1 commit intoElementsProject:masterfrom
Conversation
Contributor
|
I think you're on the right track to diagnose this bug. The issue is a little bit deeper though. The Otherwise, next time |
Author
|
@ErikDeSmedt You are right. |
Contributor
|
@rox1338 It looks like this was addressed in PR #7217 by @daywalker90. Have you managed to re-test against a more recent release? Can this PR could be closed? |
Author
|
Yep, works now! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #6996 for more info on the bug.
Disclaimer:
I did this change directly in github and didn't run any tests.
So see this as a suggestion only.
Someone with knowledge of the code needs to have a thorough look.