newaddr: various fixes for msggen and docs#7217
Merged
cdecker merged 2 commits intoElementsProject:masterfrom Apr 17, 2024
Merged
newaddr: various fixes for msggen and docs#7217cdecker merged 2 commits intoElementsProject:masterfrom
cdecker merged 2 commits intoElementsProject:masterfrom
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There were various occurences of
p2sh-segwitstill left in msggen, tests and documentation. So i removed them. I also updated some documentation files to reflect the current state ofnewaddr.Is it problematic that the values in
message NewaddrResponsechanged?Fixes: #6996
Replaces: #7146