msggen: add low level openchannel methods#7230
Merged
rustyrussell merged 2 commits intoElementsProject:masterfrom Apr 21, 2024
Merged
msggen: add low level openchannel methods#7230rustyrussell merged 2 commits intoElementsProject:masterfrom
rustyrussell merged 2 commits intoElementsProject:masterfrom
Conversation
Collaborator
Author
|
Notice that i changed the |
This was referenced Apr 17, 2024
daywalker90
force-pushed
the
openchannel_low_level
branch
from
07d54a1 to
e1a4802
Compare
cdecker
force-pushed
the
openchannel_low_level
branch
from
e1a4802 to
b78ffc5
Compare
Member
|
Rebased on top of #7218 now that it is merged into |
cdecker
requested changes
Apr 18, 2024
Member
cdecker
left a comment
cdecker
left a comment
There was a problem hiding this comment.
The change in denomination in the schema does not match the docs.
cdecker
approved these changes
Apr 18, 2024
Collaborator
Author
|
This one next please: #7238. That CI needs to be running 24/7 or we won't get them all in the 24.05 release |
daywalker90
force-pushed
the
openchannel_low_level
branch
from
b78ffc5 to
81e77c6
Compare
This was referenced May 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on: #7215 + #7217 + #7218
This PR adds the low level openchannel methods:
openchannel_abortopenchannel_bumpopenchannel_initopenchannel_signedopenchannel_updateAswell as a small fix for methods that contain a '_' like these above.