Skip to content

msggen: add commando, commando-rune, commando-listrunes, commando-blacklist methods#7269

Closed
daywalker90 wants to merge 1 commit intoElementsProject:masterfrom
daywalker90:commando
Closed

msggen: add commando, commando-rune, commando-listrunes, commando-blacklist methods#7269
daywalker90 wants to merge 1 commit intoElementsProject:masterfrom
daywalker90:commando

Conversation

@daywalker90
Copy link
Collaborator

this adds:

  • commando
  • commando-rune
  • commando-listrunes
  • commando-blacklist

But they are incomplete. Missing fields because of OneOf complexity in the schemas:

  • Commando.params, unsure what do here since object can't know what fields it will have and array would require all positional args to be present if i understand this correctly
  • CommandoResponse how to define the response of this command?
  • Commando-rune.restrictions is either a string or an array of an array of strings. Can this be simplified to just an array of strings?

@rustyrussell
Copy link
Contributor

These are deprecated except for commando itself.

Commando is recursive, though, which makes this difficult to define!

@ShahanaFarooqui
Copy link
Collaborator

Closing in favour of PR #7209.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants