Updated pb2 by make command#7376
Closed
ShahanaFarooqui wants to merge 1 commit intoElementsProject:masterfrom
Closed
Updated pb2 by make command#7376ShahanaFarooqui wants to merge 1 commit intoElementsProject:masterfrom
ShahanaFarooqui wants to merge 1 commit intoElementsProject:masterfrom
Conversation
Docker images for v24.05 were built on clean lightning directory and the published image should be running on v24.05 but it is running as v24.05-modded. Reference: ElementsProject#7370 (comment) Dockerfile's make command for lightning, auto generated contrib/pyln-grpc-proto/pyln/grpc/node_pb2.py and contrib/pyln-grpc-proto/pyln/grpc/primitive_pb2.py files with a comment removal, which resulted in modded version for CLN. If these files are identical on all setups then this PR should resolve the issue. But if not, then can we add them to .gitignore? Changelog-None.
ShahanaFarooqui
force-pushed
the
docker-version-modded-pb2
branch
from
61f15c0 to
0e1158e
Compare
Member
|
This divergence happens if |
ShahanaFarooqui
added a commit
to ShahanaFarooqui/lightning
that referenced
this pull request
Jun 12, 2024
Issue: Docker images for v24.05 were built on clean lightning directory and the published image should be running on v24.05 but it is running as v24.05-modded. Root cause: Dockerfile builder was running different versions of grpcio-tools and protobuf. It resulted in auto generated update of contrib/pyln-grpc-proto/pyln/grpc/node_pb2.py and contrib/pyln-grpc-proto/pyln/grpc/primitive_pb2.py files. Solution: Run `poetry install` before make in the dockerfile's builder stage to ensure that the grpcio-tools and protobuf versions are the same. References: ElementsProject#7370 (comment) ElementsProject#7376 (comment) Changelog-None.
Collaborator
Author
|
Thanks for the suggestion. I created another PR #7387 running Closing this PR now. |
ShahanaFarooqui
added a commit
to ShahanaFarooqui/lightning
that referenced
this pull request
Jun 12, 2024
Issue: Docker images for v24.05 were built on clean lightning directory and the published image should be running on v24.05 but it is running as v24.05-modded. Root cause: Dockerfile builder was running different versions of grpcio-tools and protobuf. It resulted in auto generated update of contrib/pyln-grpc-proto/pyln/grpc/node_pb2.py and contrib/pyln-grpc-proto/pyln/grpc/primitive_pb2.py files. Solution: Run `poetry install` before make in the dockerfile's builder stage to ensure that the grpcio-tools and protobuf versions are the same. References: ElementsProject#7370 (comment) ElementsProject#7376 (comment) Changelog-None.
ShahanaFarooqui
added a commit
to ShahanaFarooqui/lightning
that referenced
this pull request
Jun 12, 2024
Issue: Docker images for v24.05 were built on clean lightning directory and the published image should be running on v24.05 but it is running as v24.05-modded. Root cause: Dockerfile builder was running different versions of grpcio-tools and protobuf. It resulted in auto generated update of contrib/pyln-grpc-proto/pyln/grpc/node_pb2.py and contrib/pyln-grpc-proto/pyln/grpc/primitive_pb2.py files. Solution: Run `poetry install` before make in the dockerfile's builder stage to ensure that the grpcio-tools and protobuf versions are the same. References: ElementsProject#7370 (comment) ElementsProject#7376 (comment) Changelog-None.
ShahanaFarooqui
added a commit
to ShahanaFarooqui/lightning
that referenced
this pull request
Jun 12, 2024
Issue: Docker images for v24.05 were built on clean lightning directory and the published image should be running on v24.05 but it is running as v24.05-modded. Root cause: Dockerfile builder was running different versions of grpcio-tools and protobuf. It resulted in auto generated update of contrib/pyln-grpc-proto/pyln/grpc/node_pb2.py and contrib/pyln-grpc-proto/pyln/grpc/primitive_pb2.py files. Solution: Run `poetry install` before make in the dockerfile's builder stage to ensure that the grpcio-tools and protobuf versions are the same. References: ElementsProject#7370 (comment) ElementsProject#7376 (comment) Changelog-None.
rustyrussell
pushed a commit
that referenced
this pull request
Jun 13, 2024
Issue: Docker images for v24.05 were built on clean lightning directory and the published image should be running on v24.05 but it is running as v24.05-modded. Root cause: Dockerfile builder was running different versions of grpcio-tools and protobuf. It resulted in auto generated update of contrib/pyln-grpc-proto/pyln/grpc/node_pb2.py and contrib/pyln-grpc-proto/pyln/grpc/primitive_pb2.py files. Solution: Run `poetry install` before make in the dockerfile's builder stage to ensure that the grpcio-tools and protobuf versions are the same. References: #7370 (comment) #7376 (comment) Changelog-None.
ShahanaFarooqui
added a commit
to s373nZ/lightning
that referenced
this pull request
Oct 12, 2024
- Locked grpcio-tools version to fix dirty tree issue. Ref: ElementsProject#7376 (comment) - Updated python version to 3.10 for future proofing - Added manual dispatch for github action
s373nZ
pushed a commit
to s373nZ/lightning
that referenced
this pull request
Oct 15, 2024
- Locked grpcio-tools version to fix dirty tree issue. Ref: ElementsProject#7376 (comment) - Updated python version to 3.10 for future proofing - Added manual dispatch for github action
s373nZ
pushed a commit
to s373nZ/lightning
that referenced
this pull request
Oct 15, 2024
- Locked grpcio-tools version to fix dirty tree issue. Ref: ElementsProject#7376 (comment) - Updated python version to 3.10 for future proofing - Added manual dispatch for github action
ShahanaFarooqui
added a commit
that referenced
this pull request
Nov 1, 2024
- Locked grpcio-tools version to fix dirty tree issue. Ref: #7376 (comment) - Updated python version to 3.10 for future proofing - Added manual dispatch for github action
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Docker images for v24.05 were built on clean lightning directory and the published image should be running on
v24.05but it is running asv24.05-modded.Reference:
#7370 (comment)
Dockerfile's make command for lightning, auto generated
contrib/pyln-grpc-proto/pyln/grpc/node_pb2.pyandcontrib/pyln-grpc-proto/pyln/grpc/primitive_pb2.pyfiles with a comment removal, which resulted inmoddedversion for CLN.If these files are identical on all setups then this PR should resolve the issue. But if not, then can we add them to .gitignore?
Changelog-None.