script: Updating SHASUMS for updated zlib1g-dev in Ubuntu Noble#7612
Merged
ShahanaFarooqui merged 1 commit intoElementsProject:masterfrom Aug 27, 2024
Merged
Conversation
Changelog-Fixed: core lightning's reproducible build for Ubuntu v24.04 (noble).
Collaborator
|
ACK 7193f0a |
Collaborator
|
Had to build with the --no-cache option after this change, i.e., |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue:
Since we added support for Ubuntu 24.04, it was installing
zlib1g-devversion1:1.3.dfsg-3.1ubuntu2. However zlib released a minor version1:1.3.dfsg-3.1ubuntu2.1on Aug 9th.Which changed SHASUMS for our noble repro-build.sh and broke the build-release process.
Solution:
1: Either we can update the script with the latest zlib1g-dev SHASUMS Or
2: Lock the zlib1g-dev version to
1:1.3.dfsg-3.1ubuntu2.For now, I am updating the SHASUMS & version but we can re-consider locking it if the issue keeps repeating in future CLN releases (due to frequent zlib minor version updates).
Changelog-Fixed: core lightning's reproducible build for Ubuntu v24.04 (noble).