Skip to content

docs: openchannel_abort correction#7762

Merged
vincenzopalazzo merged 1 commit intoElementsProject:masterfrom
king-11:king-11/abort_doc
Oct 23, 2024
Merged

docs: openchannel_abort correction#7762
vincenzopalazzo merged 1 commit intoElementsProject:masterfrom
king-11:king-11/abort_doc

Conversation

@king-11
Copy link
Contributor

@king-11 king-11 commented Oct 23, 2024

Important

Open for merging new PRs until the next PR freeze date is confirmed!

Checklist

Before submitting the PR, ensure the following tasks are completed. If an item is not applicable to your PR, please mark it as checked:

  • The changelog has been updated in the relevant commit(s) according to the guidelines.
  • Tests have been added or modified to reflect the changes.
  • Documentation has been reviewed and updated as needed.
  • Related issues have been listed and linked, including any that this PR closes.

Copy link
Collaborator

@vincenzopalazzo vincenzopalazzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK d9dd501

@vincenzopalazzo vincenzopalazzo enabled auto-merge (rebase) October 23, 2024 19:45
@vincenzopalazzo
Copy link
Collaborator

Oh wait, we need to add Changelog-None inside the commit message like in vls

@vincenzopalazzo vincenzopalazzo merged commit 9c5e1ca into ElementsProject:master Oct 23, 2024
@vincenzopalazzo
Copy link
Collaborator

Mh this PR should not be automatically merged, looks like that the disable button in the auto-merge is not working as expected?

I remember that I disable the merge when I noted #7762 (comment)

@king-11
Copy link
Contributor Author

king-11 commented Oct 24, 2024

I think that was too late by the time they triggered the operation I was confused how to change now.

@vincenzopalazzo
Copy link
Collaborator

I think that was too late by the time they triggered the operation I was confused how to change now.

In theory the bot should not merge it if the CI fails

@king-11 king-11 deleted the king-11/abort_doc branch October 25, 2024 04:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants