add libpq for multi-arch build configuration#7827
Closed
arowser wants to merge 1 commit intoElementsProject:masterfrom
Closed
add libpq for multi-arch build configuration#7827arowser wants to merge 1 commit intoElementsProject:masterfrom
arowser wants to merge 1 commit intoElementsProject:masterfrom
Conversation
s373nZ
reviewed
Dec 6, 2024
s373nZ
suggested changes
Dec 7, 2024
Contributor
s373nZ
left a comment
s373nZ
left a comment
There was a problem hiding this comment.
My prior comment was marked as resolved, but there were no code changes or explanation? Still seeing a build error. The rest of the PR looks like it should work, though.
Can you explain how you're testing this?
Contributor
Author
|
What's your build error?
The dockerfile use to crossbuild with qemu, but the libq not exists on arm
environment, so I added the build steps for the libq library.
…On Sun, Dec 8, 2024 at 7:05 AM Se7enZ ***@***.***> wrote:
***@***.**** requested changes on this pull request.
My prior comment was marked as resolved, but there were no code changes or
explanation? Still seeing a build error. The rest of the PR looks like it
should work, though.
Can you explain how you're testing this?
—
Reply to this email directly, view it on GitHub
<#7827 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAEEDCUEYVU3KRGVWWU5IO32EN5LLAVCNFSM6AAAAABR4456JGVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDIOBWGY4TMMZUGM>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Contributor
The error is related to As I mentioned in my initial review comment, it should be an easy fix, adding the |
Contributor
|
Additionally, this PR needs the commit message updated to contain a https://github.com/ElementsProject/lightning/actions/runs/11883516546/job/33110390750?pr=7827 |
Contributor
Author
|
The errors have been resolved as you mention, if you have any other build
issues please let me know.
…On Sun, Dec 8, 2024 at 7:32 PM Se7enZ ***@***.***> wrote:
What's your build error? The dockerfile use to crossbuild with qemu, but
the libq not exists on arm environment, so I added the build steps for the
libq library.
The error is related to wget downloading the source code, which produces
the docker build error:
ERROR [base-builder 6/12] RUN wget -q https://zlib.net/fossils/zlib-1.2.13.tar.gz -O zlib.tar. 8.9s
------
> [base-builder 6/12] RUN wget -q https://zlib.net/fossils/zlib-1.2.13.tar.gz -O zlib.tar.gz && wget -q https://www.sqlite.org/2019/sqlite-src-3290000.zip -O sqlite.zip wget -q https://ftp.postgresql.org/pub/source/v17.1/postgresql-17.1.tar.gz -O postgres.tar.gz:
------
Dockerfile:96
--------------------
95 |
96 | >>> RUN wget -q https://zlib.net/fossils/zlib-1.2.13.tar.gz -O zlib.tar.gz && \
97 | >>> wget -q https://www.sqlite.org/2019/sqlite-src-3290000.zip -O sqlite.zip \
98 | >>> wget -q https://ftp.postgresql.org/pub/source/v17.1/postgresql-17.1.tar.gz -O postgres.tar.gz
99 |
--------------------
ERROR: failed to solve: process "/bin/sh -c wget -q https://zlib.net/fossils/zlib-1.2.13.tar.gz -O zlib.tar.gz && wget -q https://www.sqlite.org/2019/sqlite-src-3290000.zip -O sqlite.zip wget -q https://ftp.postgresql.org/pub/source/v17.1/postgresql-17.1.tar.gz -O postgres.tar.gz" did not complete successfully: exit code: 4
As I mentioned in my initial review comment, it should be an easy fix,
adding the && to the end of that line. Curious how you've tested this,
though, if that is breaking.
—
Reply to this email directly, view it on GitHub
<#7827 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAEEDCTXDFR63PRDBW6GRUL2EQU5FAVCNFSM6AAAAABR4456JGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKMRVGY3TGOJQGI>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Contributor
|
Not seeing any new changes. Did you forget to |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add libpq for multi-arch build configuration
Fix #7649