BOLT catchups for 25.05#8135
Merged
rustyrussell merged 6 commits intoElementsProject:masterfrom Mar 18, 2025
Merged
Conversation
Merged
rustyrussell
force-pushed
the
guilt/bolt-catchup-2505
branch
from
abd7c28 to
f2ea40a
Compare
…fore sending announcement_signatures. We have a replacement quote which is suitable here, but it comes in a later BOLT commit. Signed-off-by: Rusty Russell <[email protected]>
…ices. Signed-off-by: Rusty Russell <[email protected]>
rustyrussell
force-pushed
the
guilt/bolt-catchup-2505
branch
3 times, most recently
from
b04f0f4 to
e283cf4
Compare
Unfortunately a spec typo means the data fields are missing (PR pending), so we still patch those in. The message "your_peer_storage" got renamed to "peer_storage_retrieval", and the option "want_peer_backup_storage" was removed. Signed-off-by: Rusty Russell <[email protected]> Changelog-EXPERIMENTAL: `experimental-peer-storage` now only advertizes feature 43, not 41.
…ound `channel_announcement` handling (ElementsProject#1220)" Signed-off-by: Rusty Russell <[email protected]>
Signed-off-by: Rusty Russell <[email protected]>
Since we included the spec for it, this is a good time to implement it. I also asked chatgpt to write some unit tests. I had to mangle them a bit, but it probably saved me a few minutes. Signed-off-by: Rusty Russell <[email protected]>
rustyrussell
force-pushed
the
guilt/bolt-catchup-2505
branch
from
e283cf4 to
177a4c4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(Based on #8118)Now in masterThis includes the final peer storage spec (field name changed, one feature bit removed), and fixes up quotes now we're using what is termed "legacy close".