common/bolt11: validate public keys in routing hints#8282
Merged
rustyrussell merged 1 commit intoElementsProject:masterfrom May 16, 2025
Merged
Conversation
erickcestari
force-pushed
the
check-pubkey-private-route
branch
from
1315871 to
4acaf43
Compare
erickcestari
changed the title
Changelog-Fixed: Validated public keys in BOLT11 routing hints to prevent processing of malformed public keys.
erickcestari
force-pushed
the
check-pubkey-private-route
branch
from
4acaf43 to
e93fe72
Compare
Contributor
|
Thanks! This is great spotting. Would not have happened if we'd use a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds validation of public keys in BOLT11 routing hints to prevent processing of malformed public keys. Without this validation, invalid public keys could be accepted.
Checklist
Before submitting the PR, ensure the following tasks are completed. If an item is not applicable to your PR, please mark it as checked: