lightningd: fix log crash on weird escape lines from plugin.#8341
Merged
endothermicdev merged 1 commit intoElementsProject:masterfrom Jun 11, 2025
Merged
lightningd: fix log crash on weird escape lines from plugin.#8341endothermicdev merged 1 commit intoElementsProject:masterfrom
endothermicdev merged 1 commit intoElementsProject:masterfrom
Conversation
Apparently clboss gives us \u UTF codes. We don't support that (use UTF-8 directly)
```
126 ../sysdeps/x86_64/multiarch/strlen-vec.S: No such file or directory.
(gdb) bt
label=label@entry=0x63e2f9604db9 "char *[]") at ccan/ccan/tal/str/str.c:137
complete=complete@entry=0x7ffe9090b0f6, destroyed=destroyed@entry=0x7ffe9090b0f7) at lightningd/plugin.c:773
```
Reported-by: Ken Sedgwick
Fixes: ElementsProject#8338
Changelog-None: broken in this release
Signed-off-by: Rusty Russell <[email protected]>
endothermicdev
merged commit 03b4f47
into
ElementsProject:master
75 of 78 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apparently clboss gives us \u UTF codes. We don't support that (use UTF-8 directly)
Reported-by: Ken Sedgwick
Fixes: #8338
Changelog-None: broken in this release
Important
25.05 FREEZE MAY 05TH: Non-bugfix PRs not ready by this date will wait for 25.08.
RC1 is scheduled on May 12th, RC2 on May 16th, ...
The final release is on MAY 20TH.
Checklist
Before submitting the PR, ensure the following tasks are completed. If an item is not applicable to your PR, please mark it as checked: