plugins/libplugin-pay: Add a check for NaN values#8357
Merged
rustyrussell merged 2 commits intoElementsProject:masterfrom Sep 22, 2025
Merged
plugins/libplugin-pay: Add a check for NaN values#8357rustyrussell merged 2 commits intoElementsProject:masterfrom
rustyrussell merged 2 commits intoElementsProject:masterfrom
Conversation
added 2 commits
September 15, 2025 13:40
Add a test in `plugins/test/run-route-calc.c` that reproduces the runtime error when the fix is not applied.
Changelog-Fixed: Due to the imprecision of `htlc_max`'s type (`fp16_t`), `capacity_bias()` can return `NaN` in some cases. This leads to a runtime error when compiled with UBSan. Add a check against it.
rustyrussell
force-pushed
the
route_bug
branch
from
628ccc2 to
5e090f5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to the imprecision of
htlc_max's type (fp16_t),capacity_bias()can returnNaNin some cases. This leads to the following runtime error when compiled with UBSan:Add a check against it.
Checklist
Before submitting the PR, ensure the following tasks are completed. If an item is not applicable to your PR, please mark it as checked:
CC: @morehouse