fuzz-tests: improve fuzz-bolt11#8366
Conversation
Changelog-None: Since `bolt11_decode()` defined in `common/bolt11.c` is untested by the current BOLT ElementsProject#11 fuzz test, add a test for it.
morehouse
left a comment
morehouse
left a comment
There was a problem hiding this comment.
Some of the includes that are removed actually provide definitions that are used by the fuzz target. Presumably compilation still succeeds because some other header that's included also includes those files.
Opinions may differ on this, but generally I prefer "include what you use", even if it's already included by some other header. That way if the other header removes that include, you don't have to make changes across the whole codebase.
| #include <common/bolt11.h> | ||
| #include <common/features.h> | ||
| #include <common/setup.h> | ||
| #include <common/utils.h> |
There was a problem hiding this comment.
common/utils.h provides clean_tmpctx.
| #include <common/setup.h> | ||
| #include <common/utils.h> | ||
| #include <stddef.h> | ||
| #include <stdint.h> |
There was a problem hiding this comment.
stdint.h provides uint8_t and similar types.
| #include <stddef.h> | ||
| #include <stdint.h> | ||
| #include <stdio.h> | ||
| #include <stdlib.h> |
There was a problem hiding this comment.
stdlib.h provides abort.
| #include <stdint.h> | ||
| #include <stdio.h> | ||
| #include <stdlib.h> | ||
| #include <string.h> |
There was a problem hiding this comment.
string.h provides strlen, memcpy, memset, etc.
… test The fuzz target for BOLT ElementsProject#11 has some unnecessary #includes. Get rid of them.
Change in the fuzzing scheme of `fuzz-bolt11` led to the discovery of test inputs that result in greater in code coverage. Add these inputs to the test's seed corpus.
3 participants
Add a couple of improvements to the fuzz test for
BOLT #11operations-tests/fuzz/fuzz-bolt11. Commit the newly discovered seed corpus inputs as well.Checklist
Before submitting the PR, ensure the following tasks are completed. If an item is not applicable to your PR, please mark it as checked:
CC: @morehouse