Document listsendpays amount msat better#8384
Merged
sangbida merged 2 commits intoElementsProject:masterfrom Jun 30, 2025
Merged
Document listsendpays amount msat better#8384sangbida merged 2 commits intoElementsProject:masterfrom
sangbida merged 2 commits intoElementsProject:masterfrom
Conversation
rustyrussell
force-pushed
the
document-listsendpays-amount_msat-better
branch
from
287f0ac to
521220c
Compare
sangbida
reviewed
Jun 30, 2025
sangbida
previously approved these changes
Jun 30, 2025
Collaborator
sangbida
left a comment
sangbida
left a comment
There was a problem hiding this comment.
Looks good to me, there's only a couple places where there's double spacing.
rustyrussell
force-pushed
the
document-listsendpays-amount_msat-better
branch
from
5fdbb7a to
0aea211
Compare
…listsendpays. Sangbida and I traced back through ancient history: when the pay plugin was introduced in 0.9.0 (2019!) it already used the amount_msat parameter (then called `msatoshi`), so this case effectively "never happens". But we added a test for it just in case. Signed-off-by: Rusty Russell <[email protected]>
Among other things, injectpaymentonion insists on knowing the destination amount_msat. Signed-off-by: Rusty Russell <[email protected]>
rustyrussell
force-pushed
the
document-listsendpays-amount_msat-better
branch
from
0aea211 to
580661d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Need to specify exactly when this field is missing: turns out is "never" is.
Also, we noticed that sendonion does not refer to the modern coolness of injectpaymentonion!
Fixes: #6909
Closes: #8144
Changelog-None: doc only