fuzz-tests: fix overflow in fuzz-close_tx#8397
Merged
rustyrussell merged 2 commits intoElementsProject:masterfrom Sep 15, 2025
Merged
fuzz-tests: fix overflow in fuzz-close_tx#8397rustyrussell merged 2 commits intoElementsProject:masterfrom
fuzz-close_tx#8397rustyrussell merged 2 commits intoElementsProject:masterfrom
Conversation
added 2 commits
July 7, 2025 05:38
Changelog-None: The value WALLY_SATOSHI_PER_BTC * WALLY_BTC_MAX is equal to 2.1e15, which is much higher than the maximum capacity of a u32, which is 4.29e9. Hence, use a u64 to store this value instead.
Change in the fuzzing scheme of `fuzz-close_tx` led to the discovery of test inputs that result in greater in code coverage. Add these inputs to the test's seed corpus.
morehouse
approved these changes
Jul 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The value
WALLY_SATOSHI_PER_BTC * WALLY_BTC_MAXis equal to 2.1e15, which is much higher than the maximum capacityof a u32, which is 4.29e9.
Hence, use a u64 to store this value instead.
Checklist
Before submitting the PR, ensure the following tasks are completed. If an item is not applicable to your PR, please mark it as checked:
CC: @morehouse