splice: Update splice_info tlv to use odd version#8506
Merged
rustyrussell merged 1 commit intoElementsProject:masterfrom Nov 13, 2025
Merged
splice: Update splice_info tlv to use odd version#8506rustyrussell merged 1 commit intoElementsProject:masterfrom
rustyrussell merged 1 commit intoElementsProject:masterfrom
Conversation
ddustin
force-pushed
the
ddustin/commit_tlv_fix
branch
from
351272a to
dcc4bab
Compare
rustyrussell
force-pushed
the
ddustin/commit_tlv_fix
branch
from
dcc4bab to
9e65dce
Compare
ddustin
force-pushed
the
ddustin/commit_tlv_fix
branch
2 times, most recently
from
84708cd to
3eaeaeb
Compare
Collaborator
Author
|
CI is balking like so: It is happening in a splice related test I wonder if this test is flaking on other PRs 🤔 |
ddustin
force-pushed
the
ddustin/commit_tlv_fix
branch
2 times, most recently
from
c0e4d62 to
3b11578
Compare
Contributor
No! Changelog-None is in the commit, so this message will not be picked up! I'm re-pushing now with this in the commit msg! |
Update the tlv to use the type referenced in the spec, which also makes marks the tlv as optional. Changelog-EXPERIMENTAL: --experimental-splicing: if you have splicing enabled on a channel both nodes must upgrade in unison due to updating commitment_signeds splice_info tlv's type.
rustyrussell
force-pushed
the
ddustin/commit_tlv_fix
branch
from
3b11578 to
f0c1b3b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the tlv to use the type referenced in the spec, which also makes marks the tlv as optional.
Changelog-Changed: Breaking change -- if you have splicing enabled on a channel both nodes must upgrade in unison due to updating
commitment_signeds splice_info tlv's type.