fix: Remove "Printing" (and related) from listdatastore debug log.#8548
Merged
rustyrussell merged 1 commit intoElementsProject:masterfrom Sep 16, 2025
Merged
Conversation
Contributor
Author
|
A closer look at this function shows a few other
Maybe these should all be removed as well, but I'm lacking context. |
Changelog-None
s373nZ
force-pushed
the
remove-debug-printing
branch
from
1c2020e to
0c80dd6
Compare
Contributor
Author
|
Removed the additional debug logging statements described in #8548 (comment). |
s373nZ
changed the title
cdecker
approved these changes
Sep 15, 2025
rustyrussell
merged commit b49ccfa
into
ElementsProject:master
139 of 160 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm noticing a lot of entries in the
debuglog as such:439Z DEBUG lightningd: PrintingThere doesn't seem to be any other helpful information. Assumption is that this was a debugging exercise that wasn't fully removed, but I could be wrong. This PR removes that line in the
listdatastoreRPC.Changelog-None
Important
25.12 FREEZE October 27th: Non-bugfix PRs not ready by this date will wait for 26.03.
RC1 is scheduled on November 10th
The final release is scheduled for December 1st.
Checklist
Before submitting the PR, ensure the following tasks are completed. If an item is not applicable to your PR, please mark it as checked: