Fix bookkeeper crash#8574
Merged
rustyrussell merged 4 commits intoElementsProject:masterfrom Oct 2, 2025
Merged
Conversation
rustyrussell
force-pushed
the
guilt/bkpr-crash
branch
3 times, most recently
from
9bd4f75 to
8f9bf48
Compare
…migration. When we migrate from accounts.db, we use the `account_nonchannel_id` field. But we can replay the block chain and the channel involved is still open, we will use the `account_channel_id` field, and our duplicate detection fails. As a result, we can end up with duplicate entries in the database, which make accounting incorrect. Signed-off-by: Rusty Russell <[email protected]> Changelog-Fixed: JSON-RPC: `listchainmoves` could contain bogus duplicate entries after 25.09 bookkeeper migration.
Signed-off-by: Rusty Russell <[email protected]>
Signed-off-by: Rusty Russell <[email protected]>
rustyrussell
force-pushed
the
guilt/bkpr-crash
branch
from
8f9bf48 to
65edef6
Compare
This is based on a real database, which values changed. Signed-off-by: Rusty Russell <[email protected]>
rustyrussell
force-pushed
the
guilt/bkpr-crash
branch
from
65edef6 to
c247bc5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #8549
The root cause of this crash is that duplicates can sneak in after a migration; the symptom was that our accounting didn't add up and bookkeeper (rightly!) got upset!
Much thanks to https://github.com/s373nZ for help chasing this down.