Fix askrene infinite loop#8636
Merged
rustyrussell merged 3 commits intoElementsProject:masterfrom Nov 3, 2025
Merged
Conversation
rustyrussell
force-pushed
the
guilt/askrene-infinite-loop
branch
from
24d203c to
9b97bda
Compare
Lagrang3
reviewed
Oct 27, 2025
Collaborator
|
tACK. |
Lagrang3
approved these changes
Oct 27, 2025
rustyrussell
force-pushed
the
guilt/askrene-infinite-loop
branch
2 times, most recently
from
9593b6d to
abfcb7f
Compare
rustyrussell
force-pushed
the
guilt/askrene-infinite-loop
branch
from
abfcb7f to
59ac45c
Compare
Signed-off-by: Rusty Russell <[email protected]>
…with 1 remaining before maxparts. 1. We would find a flow. 2. refine_flow would reduce it so it doesn't deliver enough. 3. So we need to find another, but we are at the limit. 4. So we remove the flow we found. 5. Goto 1. This can be fixed by disabling a channel which we caused us to reduce the flow, so we should always make forward progress. Signed-off-by: Rusty Russell <[email protected]> Changelog-Fixed: Plugins: `askrene` could enter an infinite loop when maxparts is restricted.
rustyrussell
force-pushed
the
guilt/askrene-infinite-loop
branch
2 times, most recently
from
8f5c91c to
538d302
Compare
We have another report of looping. This maxparts code is being completely rewritten, but it's good to have a catchall for any other cases which might emerge. I had to make it customizable since our tests under valgrind are SLOW! Signed-off-by: Rusty Russell <[email protected]>
rustyrussell
force-pushed
the
guilt/askrene-infinite-loop
branch
from
538d302 to
a3865c7
Compare
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.