Skip to content

Add channel_id Filter to listpeerchannels#8766

Merged
cdecker merged 1 commit intoElementsProject:masterfrom
nepet:2548-filter-peerchannels-by-channel-id
Feb 24, 2026
Merged

Add channel_id Filter to listpeerchannels#8766
cdecker merged 1 commit intoElementsProject:masterfrom
nepet:2548-filter-peerchannels-by-channel-id

Conversation

@nepet
Copy link
Member

@nepet nepet commented Dec 7, 2025

Sometimes we don't know the short_channel_id yet (e.g the channel has not been broadcasted), but we still know the channel_id from the funding transaction. This PR adds a channel_id filter to listpeerchannels and clarifys that id, short_channel_id and channel_id are mutually exclusive.

@nepet nepet marked this pull request as ready for review December 7, 2025 16:03
@nepet nepet requested a review from cdecker as a code owner December 7, 2025 16:03
@nepet nepet force-pushed the 2548-filter-peerchannels-by-channel-id branch 4 times, most recently from 8688f02 to d1e82f4 Compare December 8, 2025 05:09
@cdecker
Copy link
Member

cdecker commented Dec 16, 2025

ACK d1e82f4

@cdecker cdecker enabled auto-merge (rebase) December 19, 2025 11:38
@rustyrussell
Copy link
Contributor

I'm assuming the second commit (which applies to a file which does not exist now) is unneccessary?

@madelinevibes madelinevibes added this to the v26.04 milestone Feb 23, 2026
Sometimes we don't know the short_channel_id yet (e.g the channel has
not been broadcasted), but we still know the channel_id from the funding
transaction. Add a channel_id filter to listpeerchannels and clarify
that id, short_channel_id and channel_id are mutually exclusive.

Changelog-Added: `listpeerchannels` now accepts a `channel_id` filter,
for cases where the `short_channel_id` is not known yet.

Signed-off-by: Peter Neuroth <[email protected]>
@nepet nepet force-pushed the 2548-filter-peerchannels-by-channel-id branch from d1e82f4 to 10f95de Compare February 24, 2026 07:06
@cdecker cdecker merged commit 2971f5d into ElementsProject:master Feb 24, 2026
86 of 89 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants