Merged
Conversation
added 2 commits
January 23, 2025 23:00
…ormat` and `Excel time format`)
This was referenced Sep 22, 2025
This was referenced Sep 29, 2025
This was referenced Oct 24, 2025
This was referenced Mar 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #694
Investigation:
The issue was not with negative timespan.
Rather it was the different time-formats excel uses to save timespans or durations.
Excel can store timespans in different formats:
P1DT2H30M)12:34)The code was parsing timespans using the method:
XmlConvert.ToTimeSpan(value.ToString()).But this method can parse only ISO 8601 format timespans.
And the reported issue was happening because that file had timespan stored as Excel Time Format.
Solution
Added different parsing approaches for ISO 8601 timespans and Excel Time Format timespans.