ci, feat - allow explicitly setting the container image#577
Merged
sudermanjr merged 13 commits intoFairwindsOps:masterfrom Aug 7, 2025
kquinsland:add-docker-support-to-gha
Merged
ci, feat - allow explicitly setting the container image#577sudermanjr merged 13 commits intoFairwindsOps:masterfrom kquinsland:add-docker-support-to-gha
sudermanjr merged 13 commits intoFairwindsOps:masterfrom
kquinsland:add-docker-support-to-gha
Conversation
but if it's not set, use podman, fall back to docker
|
|
added 9 commits
August 4, 2025 11:11
I shouldn't need this?
faster iterations. I fucking hate debugging/testing GHA
_sigh_
sudermanjr
reviewed
Aug 4, 2025
added 3 commits
August 4, 2025 12:10
Earlier I hit some issues with `docker cp`. Assert issue still presents
sudermanjr
approved these changes
Aug 5, 2025
Member
sudermanjr
left a comment
sudermanjr
left a comment
There was a problem hiding this comment.
LGTM, thanks! Just need a CLA signature now I think.
Member
|
You can ignore that dev orb failing test. |
Contributor
Author
I've signed it but still no luck. Clicking Looking at the |
sudermanjr
approved these changes
Aug 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
but if it's not set, use podman, fall back to docker
This PR fixes #576
Checklist
Description
What's the goal of this PR?
TO intelligently select between
dockerorpodmanfor pulling down the container image containingplutoWhat changes did you make?
What alternative solution should we consider, if any?