fixing ESP IDF V 5.4 compiler error [-Werror=mismatched-new-delete]#1906
Merged
zackees merged 1 commit intoFastLED:masterfrom Mar 19, 2025
Merged
fixing ESP IDF V 5.4 compiler error [-Werror=mismatched-new-delete]#1906zackees merged 1 commit intoFastLED:masterfrom
zackees merged 1 commit intoFastLED:masterfrom
Conversation
Member
|
Thank you very much! This is great and very much appreciated! |
Contributor
Author
|
you are welcome ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
compiling the library using latest EDP IDF V5.4 produce compiler warning as error [-Werror=mismatched-new-delete]
this is due to allocating using
new uint8_t[width * height] ( using [] )
while deleter is not using [] operators in scoped_ptr
fix : using scoped_array instead