Conversation
Important to note this is AI generated based on my notes the implementation
There was a problem hiding this comment.
Pull request overview
This PR enhances the Growth Node with lateral branching and flowering capabilities, making tree growth simulation more biologically realistic and versatile. It introduces new parameters for controlling dormant bud activation, flower formation, and growth preview, along with improved documentation and UI organization.
Changes:
- Added lateral branching system with dormant buds that activate based on vigor thresholds
- Introduced flowering support to convert low-vigor meristems into flower attachment points
- Added preview_iteration parameter for intermediate growth visualization
- Enhanced UI with collapsible parameter sections and preset buttons
Reviewed changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| python_classes/presets/tree_presets.py | Added growth presets dictionary and functions for applying presets |
| python_classes/presets/init.py | Exported new growth preset utilities |
| python_classes/operators.py | Added ApplyGrowthNodePreset operator for UI integration |
| python_classes/nodes/tree_function_nodes/growth_node.py | Enhanced node with lateral/flowering parameters and collapsible UI sections |
| python_classes/nodes/sockets/bool_socket.py | Created new boolean socket type for growth parameters |
| python_classes/nodes/sockets/init.py | Registered MtreeBoolSocket class |
| pyproject.toml | Updated version to 5.2.0 |
| m_tree/source/tree_functions/GrowthFunction.hpp | Added lateral branching and flowering fields |
| m_tree/source/tree_functions/GrowthFunction.cpp | Implemented lateral bud creation and activation logic |
| m_tree/python_bindings/main.cpp | Exposed new parameters to Python bindings |
| m_tree/pyproject.toml | Updated version to 5.2.0 |
| docs/growth_node_reference.md | Added comprehensive documentation for all parameters and concepts |
| blender_manifest.toml | Updated version to 5.2.0 |
| VERSION | Updated version to 5_2_0 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This involved a lot of investigating the current implementation and how the L-System worked. While fairly simple, the implementation wasn't quite there and involved a bit of a rewrite to get it to where I thought it needed to be to be usable but it's still probably a bit off.
This pull request introduces significant improvements and new features to the tree growth simulation, focusing on enhanced biological realism, user control, and flexibility. The most notable changes include the addition of lateral branching and flowering capabilities, new parameters for fine-tuning growth, and improved documentation for the Growth Node. These updates allow users to simulate a wider variety of tree forms and growth behaviors.
Major Feature Additions:
main.cpp,GrowthFunction.cpp,GrowthFunction.hpp) [1] [2] [3]main.cpp,GrowthFunction.cpp) [1] [2]Parameter and API Enhancements:
preview_iterationto control how many growth cycles are simulated, supporting intermediate previews and more interactive modeling. (main.cpp,GrowthFunction.hpp,GrowthFunction.cpp) [1] [2] [3]main.cpp) [1] [2]Algorithm and Simulation Improvements:
GrowthFunction.cpp) [1] [2] [3] [4] [5] [6] [7]GrowthFunction.cpp) [1] [2]Documentation Updates:
docs/growth_node_reference.md)Version Updates:
VERSION,blender_manifest.toml,pyproject.toml) [1] [2] [3]