feat: fix compilation problems on MSVC#233
Merged
coryan merged 3 commits intoGoogleCloudPlatform:mainfrom Feb 8, 2021
coryan:feat-compile-with-msvc
Merged
feat: fix compilation problems on MSVC#233coryan merged 3 commits intoGoogleCloudPlatform:mainfrom coryan:feat-compile-with-msvc
coryan merged 3 commits intoGoogleCloudPlatform:mainfrom
coryan:feat-compile-with-msvc
Conversation
Most of the problems were around `setenv()` and `getenv()`, which I solved by writing a small wrappers. Kept `std::getenv()` in the examples, because that is most familiar to C++ developers, had to turn off warnings from MSVC about it though. Avoid googletest regex because they are unsupported with MSVC Fix executable paths in integration tests
devbww
reviewed
Feb 7, 2021
devbww
approved these changes
Feb 8, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Most of the problems were around
setenv()andgetenv(), which Isolved by writing a small wrappers. Kept
std::getenv()in theexamples, because that is most familiar to C++ developers, had to turn
off warnings from MSVC about it though.
Avoid googletest regex because they are unsupported with MSVC
Fix executable paths in integration tests