feat: support functions::Function in Run()#340
Merged
coryan merged 1 commit intoGoogleCloudPlatform:mainfrom Mar 15, 2022
coryan:feat-declarative-signature-configuration-pr2
Merged
feat: support functions::Function in Run()#340coryan merged 1 commit intoGoogleCloudPlatform:mainfrom coryan:feat-declarative-signature-configuration-pr2
functions::Function in Run()#340coryan merged 1 commit intoGoogleCloudPlatform:mainfrom
coryan:feat-declarative-signature-configuration-pr2
Conversation
Application developers can use `functions::Function` as a wrapper for their functions in unit and integration tests. Note that we need to change the buildpacks (in a separate repository) to completely support this feature.
Codecov Report
@@ Coverage Diff @@
## main #340 +/- ##
==========================================
- Coverage 89.29% 89.24% -0.05%
==========================================
Files 98 98
Lines 2727 2733 +6
==========================================
+ Hits 2435 2439 +4
- Misses 292 294 +2
Continue to review full report at Codecov.
|
devjgm
approved these changes
Mar 15, 2022
| * When deploying code to Google Cloud Functions applications should **not** use | ||
| * this function directly. The buildpack will automatically create a `main()` | ||
| * and invoke `Run()` with the correct parameters. We recommend that application | ||
| * developers use this function only for local development and integration |
Contributor
There was a problem hiding this comment.
Here and 3 lines up where it advises not to "use this function". I think it would be clearer to say [to not] "call this function".
| /** | ||
| * Runs function wrapped by @p handler. | ||
| * | ||
| * Starts a HTTP server at the address and listening endpoint described by |
Contributor
Author
|
You tripped the auto merge, I will send those fixes in a separate PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Application developers can use
functions::Functionas a wrapper fortheir functions in unit and integration tests. Note that we need to
change the buildpacks (in a separate repository) to completely support
this feature.