fix: Firefox multi-tab download capture#101
Merged
monkeyWie merged 2 commits intoGopeedLab:mainfrom Jan 27, 2026
Merged
Conversation
Member
|
Nice, this fixes a major problem! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is designed to fix a bug in the Firefox extension which results in some downloads not being captured by the extension.
Reproduction steps for the bug in the current version are as follows:
https://gopeed.com/and the other being the Pop Os download pagehttps://system76.com/pop/download/.Downloadbutton on the Gopeed tab (download should be captured).Downloadbuttons (should fail to be captured and handled by the browser instead)In order to fix this, I changed the way the download event skip tracking works by creating a Map that associates the skip status per download rather than as one global boolean.