New display() function that uses repr#7
Closed
takluyver wants to merge 2 commits intoIRkernel:masterfrom
Closed
Conversation
Member
|
could you please add this? either at the top of the file like or to the doc comments of generally i never touch NAMESPACE and always let roxygen2 do the job. |
Member
Author
There was a problem hiding this comment.
@flying-sheep you mean like this? Does it strictly need to be on two lines? I think I've seen it like this elsewhere, but maybe not. I did use roxygen.
Member
There was a problem hiding this comment.
like this, and one line is indeed better
Member
Author
|
Excellent. This one needs a manual merge now - anything else you want to review, or shall I go ahead and merge it? |
Member
|
Merged, but git didn’t detect it |
Member
Author
|
Thanks :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #6