Fix OnChange event with post nil if the note is the same#1317
Merged
joachimmarder merged 1 commit intoJAM-Software:masterfrom Sep 2, 2025
Merged
Fix OnChange event with post nil if the note is the same#1317joachimmarder merged 1 commit intoJAM-Software:masterfrom
joachimmarder merged 1 commit intoJAM-Software:masterfrom
Conversation
I’m submitting a fix for the OnChange event, which incorrectly set the node to nil when clicking on an already selected node. This behavior is incorrect. The event should always provide the node being switched to; otherwise, nil would mean that no node is selected at all. Moreover, this worked differently in earlier versions of VT, where the parameter was never nil.
joachimmarder
approved these changes
Sep 2, 2025
Contributor
joachimmarder
left a comment
joachimmarder
left a comment
There was a problem hiding this comment.
Seems to make sense,
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I’m submitting a fix for the OnChange event, which incorrectly set the node to nil when clicking on an already selected node. This behavior is incorrect. The event should always provide the node being switched to; otherwise, nil would mean that no node is selected at all. Moreover, this worked differently in earlier versions of VT, where the parameter was never nil.