Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #302 +/- ##
==========================================
+ Coverage 38.24% 39.02% +0.78%
==========================================
Files 233 233
Lines 6139 6144 +5
Branches 1607 1608 +1
==========================================
+ Hits 2348 2398 +50
+ Misses 3394 3393 -1
+ Partials 397 353 -44 ☔ View full report in Codecov by Sentry. |
…o shared by default
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
Thanks for the library. I'm trying to use it through CMake, but I've noticed a couple of lines that could be added there.
I've changed to version number, to match the actual current number - 0.8.2.
Added install command, to allow running
cmake install, which installs the library and public headers from included directories.Directories are added to the search path using
target_include_directories, so there's no need to add them using CFlags.64 bit ARM architecture can be defined as aarch64, so I've added that to the if statement, which selects arch folder.
I've also added
BUILD_SHARED_LIBSoption. In this regard, this patch does the same as @theoparis suggested in #299, but according to CMake docs, the option string is also needed. The resultingadd_librarycall is the same, so both PR's should be able to merge.I've tried running the changes in CI, but somewhy windows clang64 errors about complaining about missing gcc. I haven't touched that part, so I assume the CI should error out without these changes too
Regards,
Vilius