Merged
Conversation
KKould
requested changes
Mar 14, 2024
Member
KKould
left a comment
There was a problem hiding this comment.
Very good code, makes me spin, please take a look at my comment
tests/slt/sql_2016/E021_11.slt
Outdated
| @@ -2,10 +2,10 @@ | |||
|
|
|||
| # TODO: POSITION() | |||
src/expression/evaluator.rs
Outdated
| let pattern = unpack(expr)?; | ||
| let str = unpack(in_expr)?; | ||
| Ok(Arc::new(DataValue::Int32( | ||
| if let Some(pos) = str.find(&pattern) { |
Member
There was a problem hiding this comment.
I think the code can be simplified here
str.find(&pattern)
.map(|pos| pos as i32 + 1)
.unwrap_or(0)
Member
|
Thanks for your contribution.🥳 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Support for
POSITION()Function.POSITION(pattern in s USING CHARACTERS/OCTETS)is not implemented since it's not supported by sqlparserIssue link: #130
What is changed and how it works?
Code changes
Check List
Tests
Side effects
Note for reviewer