Conversation
6 tasks
subdavis
force-pushed
the
server/kpf-support-v2
branch
from
21bd715 to
d5d3ec2
Compare
BryonLewis
requested changes
May 20, 2022
Collaborator
BryonLewis
left a comment
BryonLewis
left a comment
There was a problem hiding this comment.
The uploading a new dataset with the combine YML file or importing it directly seems to be fine on web.
There is a decent delay when importing combined ymls as compared to track.json/CSV files, but I'm not too worried about it because it is a feature that won't be used often.
There is an issue with client not properly deleting the groups when importing and the subsequent reloading, but I'll log that in the 1.9 review.
Just noticed some minor things, probably want to add version to the exported track json files.
Contributor
Author
|
Updated. I untangled the mess of |
subdavis
added a commit
that referenced
this pull request
May 25, 2022
* Activity Group Support (#1205) * Activity Groups * Move Image Enhancement * wip * GroupItem * Refactor Filter Controls * Complete backend support for activity groups with migrations * Refactor of GroupStore, Filter Controls, Filter List * Group filtering support * test fixes * sidebar * sidebar update * Respond to comments * Fix tests * fixing final test (#1234) Co-authored-by: BryonLewis <[email protected]> * Release 1.9.0-beta.1 * Group Creation (#1237) * WIP Group Creation * Edit type and select. Refactor TypePicker * Progress toward creation and editing of activity groups * Group membership add and remove * Update package.json * Complete Activity Group Support (#1238) * Progress on activity group editing * Progress on correct editing behavior * Finalize editing * Documentation updates * Update documentation * Add shortcut docs * Wip * KPF import support desktop * icon * Fix docs add tests * whatdo * Remove multi-file inputs * Upgrade node for electron-builder * Respond to comments * Backend fixes * Add readOnlyMode to TypePicker in GroupList * Update package.json * Include buildResources * Server/kpf support v2 (#1235) * Work in progress * Finalize KPF support * Fully move to new annotation schema in all parsers * Liint fix * Add extra meta in zip extraction * Fix * Fix merge conflict Co-authored-by: BryonLewis <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds proper KPF goroup support.
part of #850