Merged
Conversation
6 tasks
Contributor
Author
DiscussionSome areas are still incomplete
|
BryonLewis
approved these changes
May 9, 2022
Collaborator
BryonLewis
left a comment
BryonLewis
left a comment
There was a problem hiding this comment.
I think this can merge as is right now. Everything seems to be okay. The questions I have are minor and can probably be resolved in the next version.
I have a list of things that I think may want to be updated at some point in the future. This is to just keep track of them.
- Selecting a single track when items overlap for selection is difficult when adding new groups. A click will always sequentially select all trackIds if they overlap instead of one and require another click for another selection.
- Scrolling to the selected GroupId
- Tooltip hover in Group list should probably specify "GroupId" and not "TrackId". (I like clicking on it selects the group
- Selecting a group should jump to the beginning of the group timeline if not already within the timeline, much like how track selection works
- There are some closely overlapping tracks and I believe that the Layer Tooltip (toggled on in the display settings like boxes/polygons) should probably include group information as well as track information
- I kind of feel while having a group selected the existing of the mode should include clicking on an empty area. I get that it's a bit harder because after selecting a group it is automatically in edit mode.
Comment on lines
+206
to
+210
| <TypePicker | ||
| :value="trackType" | ||
| v-bind="{ lockTypes, readOnlyMode, allTypes, selected }" | ||
| @input="track.setType($event)" | ||
| /> |
Collaborator
There was a problem hiding this comment.
if its secondary or merging should the type picker be disabled?
| v-mousetrap="[ | ||
| { bind: 'a', handler: swapTabs }, | ||
| { bind: 'm', handler: doToggleMerge }, | ||
| { bind: 'g', handler: () => { groupAdd(); data.currentTab = 'attributes'; } }, |
Collaborator
There was a problem hiding this comment.
Probably add this to the keyboard/mouse shortcuts page.
| font-weight: bolder; | ||
| text-decoration: underline; | ||
| } | ||
| } No newline at end of file |
Collaborator
There was a problem hiding this comment.
small newline to the end of the file
Contributor
Author
|
Thanks Bryon, I'll address these in the next PR. |
subdavis
added a commit
that referenced
this pull request
May 19, 2022
* WIP Group Creation * Edit type and select. Refactor TypePicker * Progress toward creation and editing of activity groups * Group membership add and remove
subdavis
added a commit
that referenced
this pull request
May 25, 2022
* Activity Group Support (#1205) * Activity Groups * Move Image Enhancement * wip * GroupItem * Refactor Filter Controls * Complete backend support for activity groups with migrations * Refactor of GroupStore, Filter Controls, Filter List * Group filtering support * test fixes * sidebar * sidebar update * Respond to comments * Fix tests * fixing final test (#1234) Co-authored-by: BryonLewis <[email protected]> * Release 1.9.0-beta.1 * Group Creation (#1237) * WIP Group Creation * Edit type and select. Refactor TypePicker * Progress toward creation and editing of activity groups * Group membership add and remove * Update package.json * Complete Activity Group Support (#1238) * Progress on activity group editing * Progress on correct editing behavior * Finalize editing * Documentation updates * Update documentation * Add shortcut docs * Wip * KPF import support desktop * icon * Fix docs add tests * whatdo * Remove multi-file inputs * Upgrade node for electron-builder * Respond to comments * Backend fixes * Add readOnlyMode to TypePicker in GroupList * Update package.json * Include buildResources * Server/kpf support v2 (#1235) * Work in progress * Finalize KPF support * Fully move to new annotation schema in all parsers * Liint fix * Add extra meta in zip extraction * Fix * Fix merge conflict Co-authored-by: BryonLewis <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Things are getting easier now!
Summary
Screencast.2022-05-04.15.01.03.mp4
part of #850