Use a working "desktop" icon in docs front page#1315
Merged
Conversation
Collaborator
|
was just trying to figure out why this all of a sudden broke: Looks like they just decided to remove the icon from material design icons |
BryonLewis
previously approved these changes
Dec 13, 2022
Collaborator
BryonLewis
left a comment
BryonLewis
left a comment
There was a problem hiding this comment.
Pulled and ran a local version of the mkdocs. Looks fine. Guess I missed it after the last docs deployment a few months ago. After merge I'll do a push to the gh-pages branch.
BryonLewis
force-pushed
the
fix-broken-icon
branch
from
fd78636 to
a505f09
Compare
BryonLewis
approved these changes
Dec 15, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@zachmullen discovered a bad material icon name on the DIVE front page:
This PR replaces the broken icon specifier with this one from Fontawesome (which is also part of the mkdocs material theme):
(I don't know why the buttons are blue in my local build, but black in the deployed version.)