Conversation
client/package.json
Outdated
| "@typescript-eslint/no-unused-vars": "off", | ||
| "vue/no-template-target-blank": "off", | ||
| "vue/no-lone-template": "off", | ||
| "default-param-last": "off", |
There was a problem hiding this comment.
I'm a fan of default-param-last. Could we just disable it inline if it's needed for API stability reasons in a few places?
There was a problem hiding this comment.
When I updated the base eslint rules there were a bunch of new issues being thrown. This one was small enough I can resolve it fairly quickly. Most instances were older functions with default params that required more params added for newer features. There were only a few instances so I removed this and added in sane defaults.
client/src/use/useVuetify.ts
Outdated
|
|
||
| const useVuetify = () => { | ||
| const vm = getCurrentInstance(); | ||
| return vm?.proxy?.$vuetify || undefined; |
There was a problem hiding this comment.
Is it reasonable at runtime for this function to return undefined, or does that mean something unexpected has gone wrong?
There was a problem hiding this comment.
Good call, If this is undefined it should error out. I'll update to throw an error.
2 participants
TODO: